Unpin dask/distributed for development #1319
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1319 +/- ##
==========================================
- Coverage 85.47% 79.01% -6.47%
==========================================
Files 77 77
Lines 4242 4237 -5
Branches 790 792 +2
==========================================
- Hits 3626 3348 -278
- Misses 448 742 +294
+ Partials 168 147 -21 ☔ View full report in Codecov by Sentry. |
This reverts commit 35aa225.
| @@ -61,4 +63,4 @@ conda config --show-sources | |||
| conda list --show-channel-urls | |||
|
|
|||
| rapids-logger "Python py.test for dask-sql" | |||
| py.test $WORKSPACE -n 4 -v -m gpu --runqueries --rungpu --junitxml="$WORKSPACE/junit-dask-sql.xml" --cov-config="$WORKSPACE/.coveragerc" --cov=dask_sql --cov-report=xml:"$WORKSPACE/dask-sql-coverage.xml" --cov-report term | |||
| py.test $WORKSPACE -n $PARALLEL_LEVEL -v -m gpu --runqueries --rungpu --junitxml="$WORKSPACE/junit-dask-sql.xml" --cov-config="$WORKSPACE/.coveragerc" --cov=dask_sql --cov-report=xml:"$WORKSPACE/dask-sql-coverage.xml" --cov-report term | |||
Cargo.toml
Outdated
| @@ -6,7 +6,7 @@ description = "Bindings for DataFusion used by Dask-SQL" | |||
| readme = "README.md" | |||
| license = "Apache-2.0" | |||
| edition = "2021" | |||
| rust-version = "1.72" | |||
| rust-version = "1.73" | |||
There was a problem hiding this comment.
All for bumping! Just for my own knowledge was this a requirement or just doing it because it has been awhile? Either way is fine and this blocks nothing just want to know.
There was a problem hiding this comment.
I actually just did this to try and triage some issues we've been seeing in the aarch64 builds around hash mismatches?
https://github.com/dask-contrib/dask-sql/actions/runs/8437291358/job/23106757782
The errors in that run seemed to imply that there was something wrong with the rust 1.72 packages, but actually it turns out that this seems to be an issue with newer versions of conda-build (and/or boa), looks like 9f32482 unblocked the builds
| @@ -76,7 +76,7 @@ jobs: | |||
| channel-priority: strict | |||
| - name: Install dependencies | |||
| run: | | |||
| mamba install -c conda-forge boa conda-verify | |||
| mamba install -c conda-forge "boa<0.17" "conda-build<24.1" conda-verify | |||
There was a problem hiding this comment.
Would be interested to know what issue this constraint was addressing
There was a problem hiding this comment.
We were getting some errors on the aarch64 builds in particular around hash mismatches:
conda.CondaMultiError: Conda detected a mismatch between the expected content and downloaded content
https://github.com/dask-contrib/dask-sql/actions/runs/8637144317/job/23678689751
I've been wanting to put some time down to get a simple reproducer together but haven't yet 😕 though if you're interested I could open a PR pinning to the boa/conda-build versions used in the run above to reproduce the failures in CI
No description provided.