-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin to rust 1.72 in CI #1333
Pin to rust 1.72 in CI #1333
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1333 +/- ##
==========================================
- Coverage 85.47% 76.27% -9.21%
==========================================
Files 77 77
Lines 4242 4231 -11
Branches 790 696 -94
==========================================
- Hits 3626 3227 -399
- Misses 448 855 +407
+ Partials 168 149 -19 ☔ View full report in Codecov by Sentry. |
Just FYI -- there is a movement towards using I'm not sure if this affects environments, probably only conda-build recipes. Just wanted to share for awareness. |
Thanks for the context @bdice! Yeah have seen that migration work and expect it should be relevant if/when this impacts conda builds, though for now it looks like conda-forge only has up to rust 1.77.2 so may be a few weeks before we can check if this fix is needed / works there. Though I suppose it doesn't hurt to update the recipe here to add this specification and see what hurdles we encounter |
Have we raised an issue with the |
rerun tests |
@jakirkham an issue to add |
Would start with Narrowing down dependencies may involve some discussion |
Filed in conda-forge/rust-feedstock#192 |
Looking at rust-lang/rust#125067, it looks like the recent build issues we've been seeing in GPU CI (link) are a result of us using an outdated glibc version with our Rust toolchain.
This PR pins us to rust 1.72 across CI for now to circumvent these failures, which is consistent with the version used in our conda builds.