Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to rust 1.72 in CI #1333

Merged

Conversation

charlesbluca
Copy link
Collaborator

@charlesbluca charlesbluca commented May 13, 2024

Looking at rust-lang/rust#125067, it looks like the recent build issues we've been seeing in GPU CI (link) are a result of us using an outdated glibc version with our Rust toolchain.

This PR pins us to rust 1.72 across CI for now to circumvent these failures, which is consistent with the version used in our conda builds.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.27%. Comparing base (7600f60) to head (c6ce8e9).
Report is 5 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1333      +/-   ##
==========================================
- Coverage   85.47%   76.27%   -9.21%     
==========================================
  Files          77       77              
  Lines        4242     4231      -11     
  Branches      790      696      -94     
==========================================
- Hits         3626     3227     -399     
- Misses        448      855     +407     
+ Partials      168      149      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdice
Copy link

bdice commented May 13, 2024

Just FYI -- there is a movement towards using {{ stdlib("c") }} instead of sysroot_{{ target_platform }}. See this cuda-feedstock issue for a short description and this conda-forge issue for more details.

I'm not sure if this affects environments, probably only conda-build recipes. Just wanted to share for awareness.

@charlesbluca
Copy link
Collaborator Author

Thanks for the context @bdice! Yeah have seen that migration work and expect it should be relevant if/when this impacts conda builds, though for now it looks like conda-forge only has up to rust 1.77.2 so may be a few weeks before we can check if this fix is needed / works there.

Though I suppose it doesn't hurt to update the recipe here to add this specification and see what hurdles we encounter

@jakirkham
Copy link
Contributor

Have we raised an issue with the rust-feedstock?

@charlesbluca charlesbluca changed the title Bump sysroot_linux-64 to 2.17 in CI Pin to rust 1.72 in CI May 13, 2024
@charlesbluca
Copy link
Collaborator Author

rerun tests

@charlesbluca charlesbluca marked this pull request as ready for review May 15, 2024 12:36
@charlesbluca
Copy link
Collaborator Author

Have we raised an issue with the rust-feedstock?

@jakirkham an issue to add {{ stdlib("c") }} to rust's build dependencies, or something else?

@charlesbluca charlesbluca merged commit f34120b into dask-contrib:main May 15, 2024
19 of 25 checks passed
@jakirkham
Copy link
Contributor

Would start with rust itself

Narrowing down dependencies may involve some discussion

@charlesbluca
Copy link
Collaborator Author

Filed in conda-forge/rust-feedstock#192

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants