-
-
Notifications
You must be signed in to change notification settings - Fork 22
Conversation
args: list | ||
Extra string arguments to pass to dask-worker | ||
outputPath: string | ||
Path to the dask-worker stdout. Must start with ':'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand why a path would need to start with ":"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So don't think the :
is necessary, but can be used to specify a file on a different host by prefacing with a hostname or IP IIRC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW normally I'll do something like localhost:my_job.out
. Similar story with errorPath
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also explain how outputPath
and errorPath
could be used?
I don't get why a path needs to start with :
and how to use templating with the JOB_ID
or similar.
I believe the ":" is required by DRMAA to be considered a valid path. I am unsure why. One possibility would be to allow the user to pass an ouputTemplate and errorTemplate instead of outputPath and errorPath. Then the docstring might look something like
How does that look? |
I like it |
I think it would be great to go ahead with this doc fix and make a new release with the other recent changes. |
@edurand, do you have time to fix the merge conflicts? |
Based on your recent comments @maxnoe, I'm assuming you are happy with this, but just noticed there was an X in the review section. Was there anything else we need to address? |
Also thanks @edurand for the contribution. The doc refresh was definitely needed. :) |
As discussed in issue 72, I fleshed out the docstring for DRMAACluster. Hopefully it is now a little bit easier to use.