Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logs with local scheduler #232

Closed
wants to merge 2 commits into from
Closed

Fix logs with local scheduler #232

wants to merge 2 commits into from

Conversation

jacobtomlinson
Copy link
Member

Should fix #231.

Switched the scheduler logs method to get_logs and added a shim to the Scheduler object to ensure compatibility.

Added tests for both remote and local schedulers.

@mrocklin
Copy link
Member

+1 from me. Alternatively, should we rename get_logs to logs upstream? I'm ambivalent on the change, just thought I'd bring it up.

@jacobtomlinson
Copy link
Member Author

I have a slight preference for logs but I do not have strong feelings.

@mrocklin
Copy link
Member

Then I say go for it. Part of my motivation here is also to make sure that you feel comfortable changing things upstream, and not just in dask-kubernetes.

@quasiben
Copy link
Member

With dask/distributed#3473 is this PR still needed ?

@jacobtomlinson
Copy link
Member Author

Potentially logs should be renamed to get_logs and logs should be reinstated as the shim for backward compatibility.

Base automatically changed from master to main March 8, 2021 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to fetch logs due to AttributeError
3 participants