MAINT: provide potential solutions in warning on "dataframes not accepted" #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsievert
changed the title
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement?
It modifies message of the
TypeErrorin utils.py if Dask Dataframes are not accepted. It suggests code that may resolve the issue.I only provide
ddf.to_dask_array(...)solutions because Pandas recommends usingto_numpyinstead ofvalues: https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.values.htmlReference issues/PRs
The motivation is #84. I tried to get the code to fail with unknown chunk sizes, but the code worked. Instead, I decided to modify the message about not accepting Dask DataFrames with a potential solution.
(note: I make sure
fit_intercept in [True, False]because of #84 (comment)).