Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various k-means fixes #72

Merged
merged 7 commits into from
Oct 30, 2017
Merged

Conversation

TomAugspurger
Copy link
Member

Comes from trying to satisfy check_estimator. But that seems a bit
too restrictive.

@TomAugspurger
Copy link
Member Author

Quick update on the changes here:

  • First commit: ensure our dtypes match scikit-learn's throughout
  • Second commit: Implements a check_array. On a (10_000_000, 2) array, that adds ~0.03s of time to the fit time (47s) which I think is more than acceptable.

@TomAugspurger TomAugspurger merged commit 5f64707 into dask:master Oct 30, 2017
TomAugspurger added a commit to dsevero/dask-ml that referenced this pull request Jan 15, 2018
* BUG: Match scikit-learn dtypes for kmeans

* Add check_array for kmeans

* Remove print

* Add nose dep

* Fixup

* Move cast

* Remove complex check
@TomAugspurger TomAugspurger deleted the estimator-check branch May 22, 2018 13:41
TomAugspurger pushed a commit to TomAugspurger/dask-ml that referenced this pull request Oct 17, 2019
* dask.set_options -> dask.config.set

* Switch to using context managers in test_estimators.py

* Move dask import to top of module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant