Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for latest versions #957

Merged
merged 11 commits into from
Jan 11, 2023
Merged

Fix tests for latest versions #957

merged 11 commits into from
Jan 11, 2023

Conversation

mmccarty
Copy link
Member

@mmccarty mmccarty commented Jan 10, 2023

adding temporary upper pin on scikit-learn

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @mmccarty! Feel free to ping me if I can be of use

@mmccarty mmccarty changed the title test fixes for latest dask version test fixes for latest versions Jan 11, 2023
@mmccarty mmccarty marked this pull request as ready for review January 11, 2023 18:12
@mmccarty mmccarty self-assigned this Jan 11, 2023
@mmccarty
Copy link
Member Author

@jrbourbeau - Thanks! Ready for a review.

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmccarty! Just a few minor comments / questions

.github/workflows/tests.yaml Show resolved Hide resolved
ci/environment-3.7.yaml Show resolved Hide resolved
ci/environment-3.8.yaml Show resolved Hide resolved
ci/environment-docs.yaml Outdated Show resolved Hide resolved
@mmccarty
Copy link
Member Author

@jrbourbeau Anything further? I'm now working on scikit-learn 1.2.0 support.

@jrbourbeau jrbourbeau changed the title test fixes for latest versions Fix tests for latest versions Jan 11, 2023
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again @mmccarty

@hungbui-io
Copy link

hungbui-io commented Mar 7, 2023

Hi dask-ml team, I am wondering when dask-ml new version will be released, the one that supports python 3.10? I am trying to use latest dask-ml, dask, and dask distributed with python 3.10, but facing some library importing issues.
Any information would be much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants