Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Test ordering on distributed scheduler (#11310)" #11321

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Aug 15, 2024

This reverts commit b597ebc.

There appear to be still lingering problems with determinism. I encountered some failures in #11320

I suggest to revert until this is fixed. That PR comes with a performance penalty to make that test happy. if the test is not even working as intended I don't want us to take that hit...

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

For my own understanding, how are this and #11320 related? Maybe totally unrelated but #11320 just happens to be where you observed failures related to this test?

Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

     13 files  ± 0       13 suites  ±0   3h 7m 13s ⏱️ + 8m 10s
 13 153 tests  -  1   12 085 ✅  -  1   1 068 💤 ±0  0 ❌ ±0 
137 070 runs   - 10  118 019 ✅  - 10  19 051 💤 ±0  0 ❌ ±0 

Results for commit 69c3ea7. ± Comparison against base commit b597ebc.

This pull request removes 1 test.
dask.tests.test_order ‑ test_order_on_distributed_cluster

@jrbourbeau jrbourbeau merged commit 26a4c0f into dask:main Aug 15, 2024
24 of 25 checks passed
@fjetter
Copy link
Member Author

fjetter commented Aug 16, 2024

For my own understanding, how are this and #11320 related? Maybe totally unrelated but #11320 just happens to be where you observed failures related to this test?

yes. this is where I observed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants