Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional updates for detecting a distributed scheduler #9890

Merged
merged 2 commits into from
Jan 27, 2023

Conversation

jrbourbeau
Copy link
Member

Following dask/distributed#7482 we're no longer using the config system to say that a distributed scheduler is available. Almost all of the relevant changes needed here were included in #9808. This PR includes two similar updates (only noticed these because I saw related tests beginning to fail on main).

cc @fjetter for visibility

@jrbourbeau
Copy link
Member Author

For reference, these are the test failures this PR is fixing

FAILED dask/tests/test_distributed.py::test_zarr_in_memory_distributed_err - Failed: DID NOT RAISE <class 'RuntimeError'>
FAILED dask/tests/test_distributed.py::test_to_hdf_distributed - UserWarning: Running on a single-machine scheduler when a distributed client is active might lead to unexpected results.

I'll plan to merge this PR after CI finishes so it can be included in the release later today

@jrbourbeau jrbourbeau mentioned this pull request Jan 27, 2023
4 tasks
@jrbourbeau
Copy link
Member Author

jrbourbeau commented Jan 27, 2023

Going to go ahead and merge this so we can get the release out (all the macOS machines are currently occupied). This issue isn't mac-specific and was impacting other OS builds too. Given linux and windows builds have already passed, I have confidence this issue is also solved on macOS.

EDIT: I also ran those two test locally on my mac and they both passed

@jrbourbeau jrbourbeau merged commit 185eed2 into dask:main Jan 27, 2023
@jrbourbeau jrbourbeau deleted the default-client-test branch January 27, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant