Replace msgpack-python by msgpack #1927
Conversation
|
This looks fine to me. cc local packaging expert, @jakirkham |
|
Hmmm not sure about the CI failures, I'll need to investigate but I'll retrigger the CIs just in case. After opening the PR, I realised that msgpack was not available through conda at the moment. There is an issue in conda-forge related to this renaming conda-forge/msgpack-python-feedstock#5. |
| @@ -30,7 +30,7 @@ call deactivate | |||
| joblib ^ | |||
| jupyter_client ^ | |||
| mock ^ | |||
| msgpack-python ^ | |||
| msgpack ^ | |||
There was a problem hiding this comment.
So this part is using conda where it is still named msgpack-python. Seems to be causing the CI failure. Reverting this part should fix that issue.
There was a problem hiding this comment.
I would have guessed this is only used in Windows though, so that does not really explain the Travis failure. I pushed the change anyway.
|
Yeah the package is not likely to be renamed in |
Thanks for the details. I am wondering how this is going to pan out with the change of name in PyPI and the entry point issue detailed in #1913. If you have some suggestions on whether #1913 can be solved in setup.py I am interested. |
|
Right so as often I did not look thoroughly enough in the existing issues and it turns out there is already a PR for that. Closing in favour of #1794. |
This is the new name of the package on PyPI
msgpack not available through conda at the time of writing
|
Is this ok to go in? cc @jakirkham |
|
Thanks @lesteve. :) |
|
Now wondering if that was a question for me or @lesteve. Sorry if I merged early. |
|
This was fine to merge as far as I was concerned. I may try to do the renaming on the conda-forge side at one point. |
|
Great. Glad that this is in. Thanks @lesteve ! |
|
There is a already a conda-forge PR. Once that’s merged, the work-around here can probably be simplified. |
Agreed, once conda-forge/msgpack-python-feedstock#7 is merged, we can go back to using conda to install msgpack-python on AppVeyor. |
This is the new name of the package on PyPI. The msgpack-python PyPI page says "This package is deprecated. Install msgpack instead."
This may just fix #1913 as mentioned in #1913 (comment).
Close #1794.