Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider candidates that don't hold any dependencies in decide_worker #4925

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Consider candidates that don't hold any dependencies in decide_worker #4925

wants to merge 25 commits into from

Commits on Jun 18, 2021

  1. Test workers without deps are considered

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    5b17f55 View commit details
    Browse the repository at this point in the history

  2. Consider random subset of workers in decide_worker

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    4a81ca8 View commit details
    Browse the repository at this point in the history

  3. no-sleep test

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    c57fd72 View commit details
    Browse the repository at this point in the history

  4. Comment fastpath. Maybe this is still unnecessary?

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    d810d2d View commit details
    Browse the repository at this point in the history

  5. Pick from idle workers first

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    768d660 View commit details
    Browse the repository at this point in the history

  6. Update many_independent_leaves test

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    346ab17 View commit details
    Browse the repository at this point in the history

  7. Uppercase Mb 

    Co-authored-by: Matthew Rocklin <mrocklin@gmail.com>
    @gjoseph92 @mrocklin
    gjoseph92 and mrocklin authored Jun 18, 2021
    Configuration menu
    Copy the full SHA
    420c99e View commit details
    Browse the repository at this point in the history

  8. move N_RANDOM_WORKERS within conditional

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    0a004b2 View commit details
    Browse the repository at this point in the history

  9. Pass in sortedcontainers values, not pydict values

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    b050d14 View commit details
    Browse the repository at this point in the history

  10. Use sleep test again

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    9e99b7f View commit details
    Browse the repository at this point in the history

  11. Simpler logic

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    f6acdc4 View commit details
    Browse the repository at this point in the history

  12. 20 -> 10 

    Co-authored-by: Matthew Rocklin <mrocklin@gmail.com>
    @gjoseph92 @mrocklin
    gjoseph92 and mrocklin authored Jun 18, 2021
    Configuration menu
    Copy the full SHA
    524da73 View commit details
    Browse the repository at this point in the history

  13. Over-optimized

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    a5d37ae View commit details
    Browse the repository at this point in the history

  14. Revert "Over-optimized" 

    This reverts commit 761546db775b772a6dbbfc39218cc9e871fc3c98.
    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    5842ca8 View commit details
    Browse the repository at this point in the history

  15. random_choices_iter. over-optimized for now.

    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    a159245 View commit details
    Browse the repository at this point in the history

  16. use random.choices 

    tradeoff between speed and randomness
    @gjoseph92
    gjoseph92 committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    bb991d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2021

  1. REBASEME Actor: don't hold key references on workers

    @gjoseph92
    gjoseph92 committed Jun 19, 2021
    Configuration menu
    Copy the full SHA
    58b4bf8 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2021

  1. Remove flaky data-length check

    @gjoseph92
    gjoseph92 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    13975cb View commit details
    Browse the repository at this point in the history

  2. No randomness if < 10 workers to choose from 

    Fixes flaky `test_balance_with_restrictions`
    @gjoseph92
    gjoseph92 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    fcb165e View commit details
    Browse the repository at this point in the history

  3. Ensure decide_worker args are plain dict_values 

    @jakirkham any better ideas here?
    @gjoseph92
    gjoseph92 committed Jun 21, 2021
    Configuration menu
    Copy the full SHA
    cd382c6 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2021

  1. 1 worker for test_statistical_profiling 

    I'm a little concerned why the tasks never ran on worker `a` only on Windows though?
    @gjoseph92
    gjoseph92 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    cc57a8b View commit details
    Browse the repository at this point in the history

  2. no conditional on compiled

    @gjoseph92
    gjoseph92 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    13911bc View commit details
    Browse the repository at this point in the history

  3. rerun tests

    @gjoseph92
    gjoseph92 committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f2445fe View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. Merge remote-tracking branch 'upstream/main' into decide_worker/add-r… 

    …andom-candidates
    @gjoseph92
    gjoseph92 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    38e6b57 View commit details
    Browse the repository at this point in the history

  2. fix errant actor test

    @gjoseph92
    gjoseph92 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    5794540 View commit details
    Browse the repository at this point in the history