Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test_task_groups_update_start_stop, again #8102

Merged

Conversation

crusaderky
Copy link
Collaborator

@crusaderky crusaderky self-assigned this Aug 14, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 14, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       18 files  ±0         18 suites  ±0   9h 25m 2s ⏱️ - 56m 11s
  3 767 tests ±0    3 656 ✔️  - 1     107 💤 ±0  4 +1 
32 648 runs  ±0  31 063 ✔️  - 2  1 581 💤 +1  4 +1 

For more details on these failures, see this check.

Results for commit f500fdb. ± Comparison against base commit ac5ddc3.

♻️ This comment has been updated with latest results.

@crusaderky crusaderky force-pushed the test_task_groups_update_start_stop branch from 517e83e to f500fdb Compare August 14, 2023 12:32
@crusaderky
Copy link
Collaborator Author

Tested 100 times per environment. With anything but the sleep I was seeing time() going 1ms back into the past - on Linux and MacOSX too. Typically I was observing tg.start, which is sampled below, to be marginally less than t1 or t2.

with context_meter.meter("thread-noncpu", func=time) as m:

The only logical explanation I can come up with is that

  • on Windows, time.perf_counter() (which is used by _WindowsTime) is not perfectly synchronized between threads on Python 3.9 - or at least that's my interpretation of https://docs.python.org/3/library/time.html#time.perf_counter
  • on Linux and MacOSX, a frequent NTP sync may send time.time() back 1ms occasionally?

@crusaderky crusaderky marked this pull request as ready for review August 14, 2023 12:39
@hendrikmakait hendrikmakait merged commit 01d6ce3 into dask:main Aug 14, 2023
21 of 27 checks passed
@crusaderky crusaderky deleted the test_task_groups_update_start_stop branch August 14, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test_task_groups_update_start_stop
2 participants