Don't obfuscate fine performance metrics failures #8568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reported offline that the line
in
worker.py::apply_function_simple
failed.While this should never be possible, it happened for some reason. The way our
try...except
blocks are written caused the actual stack trace to be swallowed; the user got instead a confusingThis PR causes the actual stack trace detailing the failure of
context_meter.meter
to show up in the user's logs.