-
-
Notifications
You must be signed in to change notification settings - Fork 719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit collections metadata to scheduler #8612
Submit collections metadata to scheduler #8612
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 29 files ± 0 29 suites ±0 11h 11m 7s ⏱️ + 1h 14m 50s For more details on these failures, see this check. Results for commit ba2bb6f. ± Comparison against base commit 854a280. This pull request removes 13 and adds 9 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comment, otherwise lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @fjetter! Just one style nit.
Co-authored-by: Hendrik Makait <hendrik.makait@gmail.com>
We're already collecting client local context, e.g. with code. This is some extention to this that enriches span information with the API being used. In the future, this could be expanded with other information but for now I just included the type of collection we're submitting
cc @phofl