Add membership and commit rights document #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsievert
reviewed
Apr 10, 2019
guillaumeeb
reviewed
Apr 13, 2019
|
Thanks @guillaumeeb and @stsievert for the review |
|
If there are no further comments then I suggest that we merge this in 48 hours. All current owners have been informed of this PR and the intent to merge. |
|
+1 to merging |
jrbourbeau
approved these changes
Apr 16, 2019
jakirkham
reviewed
Apr 17, 2019
jakirkham
reviewed
Apr 17, 2019
jakirkham
reviewed
Apr 17, 2019
jakirkham
reviewed
Apr 17, 2019
Co-Authored-By: mrocklin <mrocklin@gmail.com>
TomAugspurger
approved these changes
May 8, 2019
Ideally everyone that is fairly actively involved in a project should be on board with a new addition.
|
Have pushed a few changes to address things raised here. Please let me know your thoughts on these changes. |
TomAugspurger
approved these changes
May 22, 2019
|
+1 on all of this from me |
jakirkham
approved these changes
May 22, 2019
jrbourbeau
approved these changes
May 22, 2019
Merged
|
+1 here |
jcrist
approved these changes
May 28, 2019
|
Merging in 24 hours if there are no further comments |
|
Thanks all! 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously discussed in dask/dask#3223