Skip to content
This repository has been archived by the owner on Feb 10, 2021. It is now read-only.

Add versioneer #145

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Add versioneer #145

merged 1 commit into from
Nov 16, 2017

Conversation

jcrist
Copy link
Member

@jcrist jcrist commented Nov 16, 2017

Allows checking versions on non-release builds.

Allows checking versions on non-release builds.
@martindurant
Copy link
Member

Is this really necessary? Versioneer is pretty annoying in my experience, with rogue _version.py files around and such.

@jcrist
Copy link
Member Author

jcrist commented Nov 16, 2017

Rogue _version.py files?

I've had no issues with versioneer, and in my experience it helps when integrating disparate versions from different projects, especially when testing functionality that only exists on master branches. In this specific case I need it to check if the hdfs3 version is after the latest release. Since we use it in most other dask projects I see no harm in including it here.

@jcrist
Copy link
Member Author

jcrist commented Nov 16, 2017

Failures are due to need for dask/dask#2894.

@jcrist
Copy link
Member Author

jcrist commented Nov 16, 2017

Everything is synced up now, tests pass. Merging.

@jcrist jcrist merged commit ab86706 into dask:master Nov 16, 2017
@jcrist jcrist deleted the versioneer branch November 16, 2017 19:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants