Skip to content
This repository has been archived by the owner on Feb 10, 2021. It is now read-only.

Fix bug- overriding the buffer size at file read / write #150

Merged
merged 1 commit into from
Jan 27, 2018
Merged

Fix bug- overriding the buffer size at file read / write #150

merged 1 commit into from
Jan 27, 2018

Conversation

WYishai
Copy link
Contributor

@WYishai WYishai commented Jan 25, 2018

No description provided.

@martindurant
Copy link
Member

Thank you, this looks like a useful addition.
Is the intention that the module-level variables might be altered by users? I would appreciate some extra documentation about the choices here, and maybe a couple of small tests to show that the buffer variables are correctly set.

@WYishai
Copy link
Contributor Author

WYishai commented Jan 25, 2018

I'm not sure I fully understand what you mean.
The python code initialize the native file handler with the buff parameter, but during the reading or writing operation itself it uses a buffer with different size (which was arbitrarily determind with fixed number). I change the python code to use the self.buff instead of this value, but if the user has not defined the buff parameter (==0) it uses the default value (which i moved to const, for clearance and consistency).
I have not changed these default values (except from making them consistent all over the code)...

@martindurant martindurant merged commit 3fd2c27 into dask:master Jan 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants