Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bar and group_bar interactive functions #497

Merged
merged 13 commits into from
Jun 25, 2021
Merged

Conversation

khsu2000
Copy link
Contributor

@khsu2000 khsu2000 commented Apr 6, 2021

[x] Wrote test for feature
[x] Added changes to CHANGELOG.md

Changes proposed:
Addresses #495 and adds ibar, igroup_bar, and igroup_barh functions. Adds additional tests for interactive bar functions.

@khsu2000
Copy link
Contributor Author

khsu2000 commented Apr 6, 2021

It looks like the test_read_table test needs to be updated, since the test tries to read from https://raw.githubusercontent.com/data-8/textbook/gh-pages/data/deflategate.csv, which is a 404 error. Would someone be able to advise/land a PR to fix this test?

Edit: Assuming the updated test should still use the deflategate data, I believe the updated link should be this: https://raw.githubusercontent.com/data-8/textbook/main/assets/data/deflategate.csv

@davidwagner
Copy link
Member

The link to the table should be fixed in PR #505 (now merged). Thanks for pointing that out.

@davidwagner davidwagner requested review from adnanhemani and removed request for adnanhemani June 24, 2021 23:59
@davidwagner
Copy link
Member

Looks great. Thank you!

@davidwagner davidwagner merged commit 887e727 into data-8:master Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants