Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Doc for show() method #501

Closed
wants to merge 1 commit into from

Conversation

Aashrutisingh
Copy link

[ ] Wrote test for feature
[ ] Added changes to CHANGELOG.md
[ ] Bumped version number (delete if unneeded)

Changes proposed:
Fix Doc for show() method included a simple example with explanation and usage

@davidwagner
Copy link
Member

I regret I can't accept this pull request, as it doesn't meet our needs and doesn't match our style and format. We're looking for documentation of methods that are defined in the datascience library. plt.show() is a method from matplotlib, and we're not looking to document matplotlib methods in this library, as we expect people who use this library to use our methods, not the matplotlib methods. We do our documentation via inline documentation where the method is defined, not a new standalone Python file. Thank you for your willingness to help the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants