Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test for Map.copy() #502

Merged
merged 3 commits into from
Jun 24, 2021
Merged

Added test for Map.copy() #502

merged 3 commits into from
Jun 24, 2021

Conversation

jr-42
Copy link
Contributor

@jr-42 jr-42 commented May 27, 2021

[ ] Wrote test for feature
[ ] Added changes to CHANGELOG.md

Changes proposed:
New test for copy method of Map class

  • Tests that the geojson attribute of the two Map objects are identical
  • Tests that the two Map objects are distinct

@jr-42
Copy link
Contributor Author

jr-42 commented May 27, 2021

Branch has been updated with change in PR #505 so that pipeline passes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 90.151% when pulling 26a6f4a on jr-42:test_map_copy into b3cf709 on data-8:master.

@davidwagner davidwagner merged commit 3ced351 into data-8:master Jun 24, 2021
@davidwagner
Copy link
Member

Nice, thank you for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwagner davidwagner davidwagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jr-42 @coveralls @davidwagner