Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test for map features property #503

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Added test for map features property #503

merged 3 commits into from
Jun 13, 2022

Conversation

jr-42
Copy link
Contributor

@jr-42 jr-42 commented May 27, 2021

[ ] Wrote test for feature
[ ] Added changes to CHANGELOG.md

Changes proposed:
Test for Maps 'features' property

  • Checks instance types of outputs
  • Checks all OrderedDict contains correct keys

@jr-42
Copy link
Contributor Author

jr-42 commented May 27, 2021

Branch has been updated with change in PR #505 so that pipeline passes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 90.313% when pulling 480223c on jr-42:test_map_property_feature into b3cf709 on data-8:master.

@davidwagner davidwagner merged commit e68e9a8 into data-8:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwagner davidwagner davidwagner approved these changes

@adnanhemani adnanhemani Awaiting requested review from adnanhemani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jr-42 @coveralls @davidwagner