Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests that feature is converted to list or not #589

Closed
wants to merge 1 commit into from

Conversation

Devasy23
Copy link

@Devasy23 Devasy23 commented Jun 1, 2023

This commit adds a new test function, test_map_feature_list, to the test_maps.py file. The function tests whether the features variable in the datascience.maps module is correctly converted to a list. The test creates a Map object, adds a Marker feature to it, and then checks that the features list contains the Marker feature. This test ensures that the features variable is properly converted to a list and helps maintain code quality.

[ ] Wrote test for feature
[ ] Added changes to CHANGELOG.md
[ ] Bumped version number (delete if unneeded)

Changes proposed:

This commit adds a new test function, test_map_feature_list, to the test_maps.py file. The function tests whether the features variable in the datascience.maps module is correctly converted to a list. The test creates a Map object, adds a Marker feature to it, and then checks that the features list contains the Marker feature. This test ensures that the features variable is properly converted to a list and helps maintain code quality.
Copy link
Member

@adnanhemani adnanhemani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, have you tried running this test locally? I'm not seeing an add_feature function to Map. Did you mean Map().overlay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants