Adding tests for predicates functions #598
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adnanhemani
reviewed
Aug 21, 2023
There was a problem hiding this comment.
Tests for these functions exist in the doc tests - https://github.com/data-8/datascience/blob/master/datascience/predicates.py#L17-L102
So there's no reason to add additional explicit tests here. Thanks for this anyways - please feel free to use our Coveralls to see where there might be more code that does not currently have a test - mostly Maps and Tables need the most help right now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[x] Wrote test for feature
I checked the CHANGELOG file but I couldn't see any example of writing addition of tests, so I didn't add it.
Changes proposed:
Tests are added for the functions of predicates.py file including check_iterable, not_containing and containing.