Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial and changes in functions to export to file #3

Closed
wants to merge 2 commits into from

Conversation

cronosnull
Copy link
Contributor

First part of a small tutorial of data cube use, changes on analytics_utils to export to files

cronosnull and others added 2 commits August 17, 2015 20:54
Results format differed from the expected in functions that write to files. Fixed (Testing)
@woodcockr
Copy link
Member

Pull request looks good. Could you please do these changes on the develop branch and resubmit?
The master branch is being used for releases only.

The multilingual nature of the project is a new one for us. We suggest the following might be a useful standardization:
a) In the python source code we'd like standardise on English only. No issue with this pull request because there are no new comments in the python source code
b) for the ipython notebooks we'd like to standarise on having two separate versions, one in English and one in Spanish rather than all in one as suggested.

Thanks for the contribution, we hope the changes suggested are easy enough to do. Look forward to seeing more of your work.

@cronosnull
Copy link
Contributor Author

I'll make the proposed changes and resubmit to development branch.

woodcockr added a commit that referenced this pull request Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants