Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust handling of exceptions inside share manager ECS task #1266

Open
SofiaSazonova opened this issue May 14, 2024 · 2 comments
Open

Comments

@SofiaSazonova
Copy link
Contributor

Right now if an exception is raised inside approve_share of revoke_share job the status of the share will be stuck in "in_progress" state. What do we need to do:

  1. Move share object status update to "finally" job
  2. In case dataset_lock is failed to be released, we need to think about expiry mechanism
  3. Dataset_lock can be a piece of information we may want to show in UI
@dlpzx dlpzx changed the title Make ECS job exception safe More robust handling oof exceptions inside share manager ECS task May 23, 2024
@dlpzx dlpzx changed the title More robust handling oof exceptions inside share manager ECS task More robust handling of exceptions inside share manager ECS task May 23, 2024
@dlpzx
Copy link
Contributor

dlpzx commented May 23, 2024

Hi @SofiaSazonova I am working on the share managers a lot in #1283. This could be a part X in the list of items to improve the sharing. I have added it to the list of todos

@TejasRGitHub
Copy link
Contributor

Along with the share manager, please check out this issue to add robust handling in ECS task for share verifier - #1300

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants