Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECS task fails and crashes when RDS queries return error #1300

Open
TejasRGitHub opened this issue May 23, 2024 · 3 comments
Open

ECS task fails and crashes when RDS queries return error #1300

TejasRGitHub opened this issue May 23, 2024 · 3 comments

Comments

@TejasRGitHub
Copy link
Contributor

Is your idea related to a problem? Please describe.
The way ECS verifier task has been coded, it fetches all the active shares and loops through each of them and then applies share verifier. Suppose there is failure as pointed out in the below screenshots,
image

image

In this case, the share verifier crashes and exits out without completing verification for all the shares.

Describe the solution you'd like
Add robustness by adding try except blocks on the top level and handle exceptions arising from the RDS querying. Find and check if there are any exceptions on which the share verifier should crash and stop and allow other exceptions to be logged and let the share verifier service run.

P.S. Don't attach files. Please, prefer add code snippets directly in the message body.

@SofiaSazonova
Copy link
Contributor

Hi @TejasRGitHub !
I believe this issue is the same as #1266 . Thanks for the update!
Currently it's in our ToDo-list.

@TejasRGitHub
Copy link
Contributor Author

Hi @SofiaSazonova , thanks for pointing to this issue. Although that issue is specifically towards the share manager, I will add a comments and reference this issue. Please let me know or feel free to close this issue in favour or #1266

@noah-paige
Copy link
Contributor

I think this could be a quick implementation to add the additional robustness for the share verifier ECS task by wrapping each item processed in the loop in a try/except block

I am going to nominate this issue as a candidate for v2.7 separate from #1266 which I think details additional proposed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Nominated
Development

No branches or pull requests

3 participants