You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your idea related to a problem? Please describe.
The way ECS verifier task has been coded, it fetches all the active shares and loops through each of them and then applies share verifier. Suppose there is failure as pointed out in the below screenshots,
In this case, the share verifier crashes and exits out without completing verification for all the shares.
Describe the solution you'd like
Add robustness by adding try except blocks on the top level and handle exceptions arising from the RDS querying. Find and check if there are any exceptions on which the share verifier should crash and stop and allow other exceptions to be logged and let the share verifier service run.
P.S. Don't attach files. Please, prefer add code snippets directly in the message body.
The text was updated successfully, but these errors were encountered:
Hi @SofiaSazonova , thanks for pointing to this issue. Although that issue is specifically towards the share manager, I will add a comments and reference this issue. Please let me know or feel free to close this issue in favour or #1266
I think this could be a quick implementation to add the additional robustness for the share verifier ECS task by wrapping each item processed in the loop in a try/except block
I am going to nominate this issue as a candidate for v2.7 separate from #1266 which I think details additional proposed changes
Is your idea related to a problem? Please describe.
The way ECS verifier task has been coded, it fetches all the active shares and loops through each of them and then applies share verifier. Suppose there is failure as pointed out in the below screenshots,
In this case, the share verifier crashes and exits out without completing verification for all the shares.
Describe the solution you'd like
Add robustness by adding try except blocks on the top level and handle exceptions arising from the RDS querying. Find and check if there are any exceptions on which the share verifier should crash and stop and allow other exceptions to be logged and let the share verifier service run.
P.S. Don't attach files. Please, prefer add code snippets directly in the message body.
The text was updated successfully, but these errors were encountered: