modularization: Datasets modularization pt.4 #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved dataset table column to modules
Renamed table column to the python's convention format
Added dataset module to config.json
Moved database table service
Renamed DatasetTable to DatasetTableService to avoid collisions with models.DatasetTable
Moved DatasetTableColumn to modules
Currently, only async handlers require dedicated loading. Long-running tasks (scheduled tasks) might not need to have a dedicated loading mode
Extracted code from glue to glue_column_handler Added handlers importing for datasets
Extracted the code for dataset table handler
Extracted the long-running task for datasets
Extracted the subscription service into datasets
Extracted the handler to get table columns
Needed for migration for modules
Fixed tests and added new for dataset module
Glossaries had different target types and had to be treated differently
Created API for glossaries to use modularization
Added and fixed tests
Moved FeedRegistry to gql since it's more appropriate place for this Started using registry to provide types Renaming and small fixes
Solve circular dependecy for redshift. It should go away after the migration of redshift
There is a few of circular imports. It's a first attempt to solve it
# Conflicts: # backend/dataall/modules/datasets/handlers/glue_column_handler.py # tests/api/test_dataset_table.py
…sets-mod-part3 # Conflicts: # backend/dataall/db/api/__init__.py # backend/dataall/modules/datasets/__init__.py # backend/dataall/modules/datasets/api/__init__.py # backend/dataall/modules/datasets/db/models.py
# Conflicts: # backend/dataall/modules/datasets/db/models.py
dbalintx
reviewed
May 4, 2023
backend/dataall/modules/datasets/handlers/glue_column_handler.py
Outdated
Show resolved
Hide resolved
dbalintx
reviewed
May 4, 2023
Co-authored-by: dbalintx <132444646+dbalintx@users.noreply.github.com>
dbalintx
approved these changes
May 4, 2023
dlpzx
changed the title
dlpzx
pushed a commit
to dlpzx/aws-dataall
that referenced
this pull request
May 25, 2023
### Feature or Bugfix - Refactoring ### Detail Refactoring of DatasetTable: Get rid of ElasticSearch connection for every request. Created a lazy way to establish connection. ### Relates data-dot-all#412 and data-dot-all#295 By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: dbalintx <132444646+dbalintx@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Refactoring of DatasetTable:
Get rid of ElasticSearch connection for every request. Created a lazy way to establish connection.
Relates
#412 and #295
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.