Add a way to tag identity to Motion for Singularity telemetry #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #398 +/- ##
==========================================
- Coverage 73.94% 71.15% -2.79%
==========================================
Files 147 148 +1
Lines 9632 9658 +26
==========================================
- Hits 7122 6872 -250
- Misses 1770 2076 +306
+ Partials 740 710 -30
☔ View full report in Codecov by Sentry. |
xinaxu
added a commit
to filecoin-project/motion
that referenced
this pull request
Oct 23, 2023
Context: - #174 Previous steps - data-preservation-programs/singularity#398 - data-preservation-programs/singularity-metrics@46bc0d3 Next step: - Create Grafana dashboard with tagged motion telemetry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Offer an API to set the identity as a global variable in the database. This identity is only settable via API call.
All telemetries published will include this identity as part of payload.
This is the first step for filecoin-project/motion#174