Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node version matching production. #408

Merged

Conversation

jtorreggiani
Copy link
Contributor

@jtorreggiani jtorreggiani commented Apr 13, 2023

PR Overview

Updating the .nvmrc file to include a version of node that matches what is used in production.

Type of contribution

  • Code
  • Documentation

Reference: Issue or Pull Request (PR)

Description of Changes

We want to make sure we are using the same node version that is used in production. This will help avoid BAD_ENGINE errors.

Before and After for UI Updates

N/A

For PR Reviewer

  • Does this file change the yarn.lock, package.json or package-lock.json file? If so, why?
  • If this pr contains mobile and desktop changes, did you test on IphoneXr and desktop views?
  • Does this file match the related tickets linked figma file, or does it pass the visual smell test?
  • If this file contains javascript, does the javascript pass the smell test?
  • If you don't feel super confident in your review, did you assign someone more senior to double check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant