Use groups instead of mapping in the benchmark. #424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wilko77
approved these changes
Sep 9, 2019
benchmarking/benchmark.py
Outdated
|
|
||
|
|
||
| def compose_result(status, tt, experiment, sizes, threshold): | ||
| tp, tn, fp, fn = tt | ||
| positives, negatives, false_positives = tt | ||
| sizes_dic = {'size_{}'.format(chr(97 + i)): sizes[i] for i in range(len(sizes))} |
There was a problem hiding this comment.
what's that for? It isn't used anywhere. I guess you eventually will build the 'sizes' section in the result with that. Am I right?
There was a problem hiding this comment.
You're right. I was trying to split the multi-party linkage benchmark update in two PRs, but this is a remaining of a wrong split. It becomes useful in the following PR.
gusmith
force-pushed
the
benchmark-groups
branch
from
e57f574
to
2251765
Compare
|
Sorry Wilko, doing some force-push to rebase on top of latest develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of two PRs related to multi party linkage.
First one: using groups instead of mappings, and introducing a new metric for the grouping output.
In this PR, it is still hard coded to be ran for two parties only.