Refactor cache progress to use redis hash #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
wilko77
approved these changes
Sep 24, 2019
hardbyte
force-pushed
the
refactor-cache
branch
from
8de09a5
to
f4ee78a
Compare
hardbyte
force-pushed
the
refactor-chache-to-use-hash
branch
from
6a51d59
to
9281bc5
Compare
hardbyte
force-pushed
the
refactor-cache
branch
from
f4ee78a
to
3c46532
Compare
hardbyte
force-pushed
the
refactor-chache-to-use-hash
branch
from
9281bc5
to
09ea731
Compare
hardbyte
force-pushed
the
refactor-chache-to-use-hash
branch
from
09ea731
to
476ba74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon the refactoring in #430 by changing the internal redis data structure used to store the progress from a string to a hash.
This will enable us to store other data such as state in the same redis hash object.