Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Benchmark test on CI runs 3 parties linkage #433

Merged
merged 3 commits into from
Sep 25, 2019

Conversation

gusmith
Copy link
Contributor

@gusmith gusmith commented Sep 24, 2019

Threshold 0.8 is chosen for the 3 party case because the results were quite good.

@gusmith gusmith self-assigned this Sep 24, 2019
@gusmith gusmith requested review from wilko77 and removed request for hardbyte September 24, 2019 23:49
Copy link
Collaborator

@wilko77 wilko77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed, I would prefer to have a sensible threshold in the two party case as well.

@gusmith
Copy link
Contributor Author

gusmith commented Sep 25, 2019

On my machine, results from running the benchmark (remove all the unnecessary values), the provided json may not be valid as I'm removing by hand the values:

{
  'sizes': ['100K', '100K'],
  'threshold': 0.95,
  'groups_results': {
     'accuracy': 0.43175537666706715,
     'false_positives': 0,
     'negatives': 28377,
     'positives': 21561}
  'timings': {'runtime': 27.936643},
},
{
  'sizes': ['100K', '100K'],
  'threshold': 0.8,
  'groups_results': {
    'accuracy': 0.9962553566422364,
    'false_positives': 7289,
    'negatives': 187,
    'positives': 49751
  },
  'timings': {'runtime': 38.349424}
}

So running the 2 parties 100K experiment improves drastically the accuracy using a threshold of 0.8 instead of 0.95, but increases runtime by 10 seconds. So I'll include the change in this PR too.

@gusmith gusmith merged commit 0026f58 into develop Sep 25, 2019
@gusmith gusmith deleted the feature-3parties-benchmark-on-tests branch September 25, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants