Remove redundant tests #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fact that a run is progressing is tested by running the whole run.
…ogressing validly. Thus remove some unused utility methods.
wilko77
approved these changes
Nov 21, 2019
| @@ -362,7 +350,7 @@ def from_string(state): | |||
| return State.completed | |||
|
|
|||
|
|
|||
| def has_not_progressed_invalidly(status_old, status_new): | |||
| def has_progressed_validly(status_old, status_new): | |||
There was a problem hiding this comment.
I do not not approve of this change ;)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #457
Currently, the entity-service is trying to do unit tests in an end to end way. For example, the removed tests were about testing the run endpoint by creating full runs.
These full runs are already created in a number of other tests (e.g. the ones where we check the validity of the output of a run).
So in this PR, I removed some tests about intermediary results such as checking that a run is progressing normally and testing the run endpoint.
However, this is slightly against the tests visions where each test describe what it is "unit" testing. In the approach I started, we run the whole end to end pipeline and on the way test each part.
But from 327 tests running in 7m 40s on my machine with a simple local deployment on the service, the PR reduced the number of tests to 283 ran in 6m 35s with the same deployment.