Use encodings from db instead of minio #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix up opentracing spans
Remove unused ijson import
Remove unused ijson import Remove convert_encodings_from_json_to_binary and unused serialization.
Also ensure encodings are returned in order
hardbyte
force-pushed
the
feature-use-encodings-from-db
branch
from
b7781f8
to
631aa67
Compare
wilko77
approved these changes
Mar 15, 2020
| # retrieval of encoding ids should be much faster than insertion | ||
| assert fetch_time < elapsed_time | ||
|
|
||
| assert id_fetch_time < elapsed_time |
There was a problem hiding this comment.
these timing assertions might not always hold. (e.g. if there is a load spike in the db) So should we really fail if it goes wrong once?
|
|
||
| parent_span = g.flask_tracer.get_span() | ||
|
|
||
| def precheck_encoding_upload(project_id, headers, parent_span): |
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds ontop of PR that fixes Jaeger: #523This PR completes the switch from storing encodings in minio to postgres. It makes several short term assumptions such as assuming there will be one default block per data provider and that encoding ids will be sequential non-repeating integers. These assumptions will be addressed over the next several sprints.
Chunking information previously included object store filenames, now each chunk comprises a data provider ID and a range of encoding ids. E.g.
dp_id=45, range=[2000,5000], the comparison task now queries the database to fetch these encodings (currently ignoring blocks).Tracing child spans was not working inside of celery tasks so I've fixed the tasks I touched.