Temporary object store credentials endpoint #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardbyte
force-pushed
the
temporary-object-store-credentials-endpoint
branch
from
271f417
to
f2176e8
Compare
hardbyte
force-pushed
the
temporary-object-store-credentials-endpoint
branch
2 times, most recently
from
642805b
to
3807e4e
Compare
hardbyte
force-pushed
the
temporary-object-store-credentials-endpoint
branch
from
3807e4e
to
8a569fd
Compare
wilko77
approved these changes
Apr 21, 2020
| @@ -16,14 +15,19 @@ services: | |||
| image: data61/anonlink-app:${TAG:-latest} | |||
| environment: | |||
| - SERVER=http://nginx:8851 | |||
| - INITIAL_DELAY=20 | |||
There was a problem hiding this comment.
you removed the env var INITIAL_DELAY in a couple of places. Who uses this? What is it defaulting to now?
There was a problem hiding this comment.
It is an optional environment variable used by both the integration tests and end to end tests - I probably shouldn't have deleted them as they serve as documentation.
Note I also added a small sleep in the docker command for the integrationtests container
This was referenced Apr 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint to retrieve temporary object store credentials.
The design is documented here. The main thrust of this is complete, but I still haven't finished the k8s deployment side of things. In particular I'd like to get the k8s initialization working and remove any object store credentials before adding support to open the minio object store to the internet.