Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ingress #587

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Update ingress #587

merged 2 commits into from
Feb 9, 2021

Conversation

hardbyte
Copy link
Collaborator

@hardbyte hardbyte commented Dec 1, 2020 •
edited
Loading

  • Allows user to specify a path e.g. a prefix.
  • remove default ingress config from values file (as users have to override them all)
  • Adds a note to the documentation around ingress configuration with example for nginx.

The pipeline appears to be failing (here and on develop) due to this recently fixed issue:
microsoft/azure-pipelines-tasks#13911

@hardbyte hardbyte changed the title Update ingress to include path and to Update ingress Dec 1, 2020
@hardbyte hardbyte requested a review from wilko77 December 4, 2020 07:10
@hardbyte
Copy link
Collaborator Author

hardbyte commented Dec 21, 2020 •
edited
Loading

I'll rebase this after #596 is merged in (just got to fix the docs builder)
Rebased

@hardbyte
Update ingress to include path
b79aef2 
Remove defaults from values file for ingress settings
Fixed two typos in the templates.
@hardbyte
Documents ingress configuration
e56d501
wilko77
wilko77 approved these changes Feb 8, 2021
View reviewed changes
Copy link
Collaborator

@wilko77 wilko77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hardbyte hardbyte merged commit 67092f4 into develop Feb 9, 2021
@hardbyte hardbyte deleted the update-ingress-template branch February 9, 2021 03:18
@hardbyte hardbyte added this to the Entity Service v1.14 milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilko77 wilko77 wilko77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Entity Service v1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@hardbyte @wilko77