Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix - Minio python API now requires a "DeleteObject" #608

Merged
merged 1 commit into from
Feb 18, 2021
Merged

Bug fix - Minio python API now requires a "DeleteObject" #608

merged 1 commit into from
Feb 18, 2021

Conversation

hardbyte
Copy link
Collaborator

This object store deletion was only triggered in benchmarks and not in tests.

@hardbyte hardbyte force-pushed the fix-deleting-merged-objects-from-minio branch from f4db3fb to 437d686 Compare February 17, 2021 03:04
wilko77
wilko77 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Collaborator

@wilko77 wilko77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!
So we don't run at least one test that's big enough to call merge_files?

@hardbyte
Copy link
Collaborator Author

Yeah I guess not, also odd that it seemed sporadic. That's never great

@hardbyte hardbyte merged commit b4cee6d into develop Feb 18, 2021
@hardbyte hardbyte deleted the fix-deleting-merged-objects-from-minio branch February 18, 2021 01:55
@hardbyte hardbyte added this to the Entity Service v1.14 milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilko77 wilko77 wilko77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Entity Service v1.14
Development

Successfully merging this pull request may close these issues.
2 participants
@hardbyte @wilko77