Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FlinkFlowStepStats.getCountersFor should return counter names, not groupCounter names #61

Closed
kkrugler opened this issue May 7, 2016 · 3 comments

Comments

@kkrugler
Copy link
Contributor

kkrugler commented May 7, 2016

Currently it returns the entire <group name> -> <key name> string, but callers expect to get back just the counter name (which they will then combine with the group name).

The current result is that trying to get counters for a completed Flow will return 0.

I've made a change and confirmed it fixes the issue, but need to add a test and put that all in a branch for a pull request.

@fhueske
Copy link
Contributor

fhueske commented May 9, 2016

Thanks for reporting @kkrugler.
Looking forward to the PR. Once the issue is fixed, we can push out a 0.3 release.

kkrugler added a commit to kkrugler/cascading-flink that referenced this issue May 9, 2016
@kkrugler
Copy link
Contributor Author

kkrugler commented May 9, 2016

Pull request created (#63).

@fhueske
Copy link
Contributor

fhueske commented May 17, 2016

Pull request was merged.

@fhueske fhueske closed this as completed May 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants