-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor mysql server for runtime #274
Merged
mlycore
merged 29 commits into
database-mesh:master
from
xuanyuan300:refactor-mysqlserver-codec6
Aug 25, 2022
Merged
Refactor mysql server for runtime #274
mlycore
merged 29 commits into
database-mesh:master
from
xuanyuan300:refactor-mysqlserver-codec6
Aug 25, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
…yuan300/pisanix into refactor-mysqlserver-codec6 Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
…pisanix into refactor-mysqlserver-codec6 Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
xuanyuan300
added
type:refactor
Refactor some design or implementation
app:pisa-proxy
Pisa-Proxy related changes
in:runtime
Runtime related changes
in:protocol
Protocol related changes
labels
Aug 25, 2022
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
+ Coverage 66.97% 70.30% +3.32%
==========================================
Files 7 6 -1
Lines 427 495 +68
==========================================
+ Hits 286 348 +62
- Misses 133 137 +4
- Partials 8 10 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
Signed-off-by: xuanyuan300 <xuanyuan300@gmail.com>
mlycore
approved these changes
Aug 25, 2022
wbtlb
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app:pisa-proxy
Pisa-Proxy related changes
in:protocol
Protocol related changes
in:runtime
Runtime related changes
size/XXL
type:refactor
Refactor some design or implementation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed:
The goal of this refactor is to improve the scalability of the runtime, Users can implements their own handling logic.
The important changes as follows.
Trait:
MySQLService
trait to handle the command for mysql protocol.Any third-part can be implements
MySQLSerivce
.Struct:
MySQLInstance
struct to start aMySQLService
instance, it can be execute the method ofMySQLSerice
trait.PisaMySQLService
struct to implements theMySQLService
trait as a default implemenets in thePisa-Proxy
internal.Codec:
HandshakeCodec
to parsing mysql handshake packet.PacketCodec
to parsing mysql protocol.Note:
This pr also fix some
unused result
warn.