Suppress user and password info output via Config structure. #947
Conversation
|
Thanks for the contribution! Please review the labels and make any necessary changes. |
| self.clickhouse_handler_thread_num, self.flight_api_address, self.http_api_address, self.metric_api_address, | ||
| self.store_api_address, self.config_file) | ||
| } | ||
| } |
There was a problem hiding this comment.
maybe should add new line : )
| #[derive(Clone, Debug, serde::Deserialize, PartialEq, StructOpt, StructOptToml)] | ||
| impl fmt::Debug for Config{ | ||
| fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { | ||
| write!(f, "{{ log_level: \"{}\", log_dir: \"{}\", num_cpus: {}, mysql_handler_host: \"{}\", |
There was a problem hiding this comment.
It looks like a JSON. maybe we can consider the following two implementations:
- Reference https://github.com/rust-lang/rust/blob/master/library/core/src/fmt/mod.rs#L523 to implemented.
or
- Use serde::Serialize and skip field attribute
There was a problem hiding this comment.
I will follow up. Thx.
There was a problem hiding this comment.
Or we can implement the following code and change the type of store_api_password to Password
struct Password {
plain_text : String
}
impl Debug for Password {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
write!(f, "******");
}
}
|
Please review and give more precious advice. |
|
We need implement to_string() function to work with env_helper! macro. |
|
|
||
| #[structopt(long, short = "c", env = CONFIG_FILE, default_value = "")] | ||
| pub config_file: String, | ||
| } | ||
| #[derive(Clone, serde::Deserialize, PartialEq, StructOpt, StructOptToml)] |
| write!(f, "******") | ||
| } | ||
| } | ||
| #[derive(Clone, serde::Deserialize, PartialEq, StructOpt, StructOptToml)] |
There was a problem hiding this comment.
This Rust Assist extesion looks good. Do we need this format tool？
There was a problem hiding this comment.
We use rust-fmt to format the code. You can use make lint to check the format
|
Hello @wangzhen11aaa, 🎉 Thank you for opening the pull request! 🎉 |
Need to implement ToString trait for User and Password. |
|
CI Passed |
I hereby agree to the terms of the CLA available at: https://datafuse.rs/policies/cla/
Summary
Draft pull request. May not the best solution, Please give advice about the improvement.
Changelog
Rewrite the Debug trait for the Config structure. This fix will affect the extension of the Config, and seems not the best answer.
Improvement
Not for changelog (changelog entry is not required)
Related Issues
fixes #935
Test Plan
Unit Tests
Stateless Tests