Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run summary stats #33

Closed
nsheff opened this issue Feb 9, 2018 · 13 comments
Closed

Run summary stats #33

nsheff opened this issue Feb 9, 2018 · 13 comments
Assignees
Milestone

Comments

@nsheff
Copy link
Member

nsheff commented Feb 9, 2018

Along with the UI decouple (#30) we should have the results page show some summary stats on the run:

  • start time?
  • end time?
  • elapsed time?
  • results URL
  • filename uploaded
  • genome selected
  • universe selected
  • database selected

anything else?

@nmagee
Copy link
Member

nmagee commented Feb 9, 2018

I have a bit of an interest in capturing the users originating IP address. That would let me do a bit of investigation on schools and campuses that are touching LOLA, but it’s not a burning hot priority.

@nsheff
Copy link
Member Author

nsheff commented Feb 28, 2018

In tandem with #30

@nsheff nsheff added this to the v1.2 milestone Feb 28, 2018
@vpnagraj
Copy link
Collaborator

i've taken a first pass at collecting / including run summary info (for an example see http://dev.lolaweb.databio.org/?key=OAV4E2X3L7YTPUW)

@nmagee and @nsheff when you get a chance let me know what you think

@nsheff
Copy link
Member Author

nsheff commented Mar 14, 2018

that is excellent. what do you think of putting it on the left, under the display sliders, so it doesn't take up the valuable central space?

@vpnagraj
Copy link
Collaborator

@nsheff good call ... only issue is that the table won't fit on the left side, so i'm using a text output instead:

http://dev.lolaweb.databio.org/?key=UDYOXT3MC1E2VF7

@nsheff
Copy link
Member Author

nsheff commented Mar 14, 2018

Yeah, that makes sense. Unfortunately, the text output looks bad though, and introduces that horizontal scrollbar.

@vpnagraj
Copy link
Collaborator

ok another attempt (this time with the table transposed):

http://dev.lolaweb.databio.org/?key=UDYOXT3MC1E2VF7

@nsheff
Copy link
Member Author

nsheff commented Mar 15, 2018

Yeah, that's what I was imagining!

@vpnagraj
Copy link
Collaborator

@nsheff 🔮
@nmagee i'm punting on caching the ip address since it's not (yet) readily available in the shiny client data fields (rstudio/shiny#141) ... that said, with google analytics i think we can get at some of that information

@nsheff
Copy link
Member Author

nsheff commented Mar 16, 2018

The current table cuts off values on the right side (they don't quite fit in the left menu).
example, heres what I see:

Start 2018-03-16 13:4
End 2018-03-16 13:4
Elapsed 188 seconds
Cache VAJOK1TQ3ME
Regions lamina
Genome hg19
Universe activeDHS_univ
Database Core

Maybe make it smaller text?? it needs to fit...

@nsheff nsheff reopened this Mar 16, 2018
@vpnagraj
Copy link
Collaborator

now using font-size:10px; for run summary table, and also including commit hash from #59

@nsheff
Copy link
Member Author

nsheff commented Mar 16, 2018

does that make it fit?

@nsheff
Copy link
Member Author

nsheff commented Mar 16, 2018

looks fine to me now.

@nsheff nsheff closed this as completed Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants