Merge pull request #118 from vreuter/safe_copy

Respect protected members

doc/source/changelog.rst

@@ -1,5 +1,9 @@
 Changelog
 ******************************
+- **v0.9.2** (*2019-01-30*):
+
+    - Never echo protected-looking attribute request.
+
 - **v0.9.1** (*2019-01-29*):
 
     - Fixed a bug in NGSTk that caused errors for read counting functions on 

pypiper/AttributeDict.py

@@ -46,7 +46,8 @@ def __getattr__(self, name):
         if name in self.__dict__.keys():
             return self.name
         else:
-            if self.return_defaults:
+            if self.return_defaults and not \
+                    (name.startswith("__") and name.endswith("__")):
                 # If this object has default mode on, then we should
                 # simply return the name of the requested attribute as
                 # a default, if no attribute with that name exists.

pypiper/_version.py

@@ -1 +1 @@
-__version__ = "0.9.1"
+__version__ = "0.9.2"

tests/test_attribute_dict.py

@@ -0,0 +1,16 @@
+""" Tests for pypiper implementation of AttributeDict """
+
+import pytest
+from pypiper import AttributeDict as AD
+
+
+@pytest.mark.parametrize("base", ["random", "irrelevant", "arbitrary"])
+@pytest.mark.parametrize("protect", [False, True])
+def test_echo_respects_protected(base, protect):
+    """ Regardless of AttributeDict behavior, protected member isn't echoed. """
+    ad = AD({}, default=True)
+    if protect:
+        with pytest.raises(AttributeError):
+            ad.__getattr__("__{}__".format(base))
+    else:
+        assert base == ad.__getattr__(base)