Add UUID to uniquely identify a deployment state #1595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
requested review from
andrewnester and
pietern
and removed request for
andrewnester
andrewnester
approved these changes
Jul 16, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
pietern
reviewed
Jul 16, 2024
andrewnester
added a commit
that referenced
this pull request
Jul 18, 2024
CLI: * [Fix] Do not buffer files in memory when downloading ([#1599](#1599)). Bundles: * Allow artifacts (JARs, wheels) to be uploaded to UC Volumes ([#1591](#1591)). * Upgrade TF provider to 1.48.3 ([#1600](#1600)). * Fixed job name normalisation for bundle generate ([#1601](#1601)). Internal: * Add UUID to uniquely identify a deployment state ([#1595](#1595)). * Track multiple locations associated with a `dyn.Value` ([#1510](#1510)). * Attribute Terraform API requests the CLI ([#1598](#1598)). * Use local Terraform state only when lineage match ([#1588](#1588)). * Implement readahead cache for Workspace API calls ([#1582](#1582)). Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.43.0 to 0.43.2 ([#1594](#1594)).
Closed
andrewnester
added a commit
that referenced
this pull request
Jul 18, 2024
CLI: * Do not buffer files in memory when downloading ([#1599](#1599)). Bundles: * Allow artifacts (JARs, wheels) to be uploaded to UC Volumes ([#1591](#1591)). * Upgrade TF provider to 1.48.3 ([#1600](#1600)). * Fixed job name normalisation for bundle generate ([#1601](#1601)). Internal: * Add UUID to uniquely identify a deployment state ([#1595](#1595)). * Track multiple locations associated with a `dyn.Value` ([#1510](#1510)). * Attribute Terraform API requests the CLI ([#1598](#1598)). * Implement readahead cache for Workspace API calls ([#1582](#1582)). * Use local Terraform state only when lineage match ([#1588](#1588)). Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.43.0 to 0.43.2 ([#1594](#1594)).
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
CLI: * Do not buffer files in memory when downloading ([#1599](#1599)). Bundles: * Allow artifacts (JARs, wheels) to be uploaded to UC Volumes ([#1591](#1591)). * Upgrade TF provider to 1.48.3 ([#1600](#1600)). * Fixed job name normalisation for bundle generate ([#1601](#1601)). Internal: * Add UUID to uniquely identify a deployment state ([#1595](#1595)). * Track multiple locations associated with a `dyn.Value` ([#1510](#1510)). * Attribute Terraform API requests the CLI ([#1598](#1598)). * Implement readahead cache for Workspace API calls ([#1582](#1582)). * Use local Terraform state only when lineage match ([#1588](#1588)). * Add read-only mode for extension aware workspace filer ([#1609](#1609)). Dependency updates: * Bump github.com/databricks/databricks-sdk-go from 0.43.0 to 0.43.2 ([#1594](#1594)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We need a mechanism to invalidate the locally cached deployment state if a user uses the same working directory to deploy to multiple distinct deployments (separate targets, root_paths or even hosts).
This PR just adds the UUID to the deployment state in preparation for invalidating this cache. The actual invalidation will follow up at a later date (tracked in internal backlog).
Tests
Unit test. Manually checked the deployment state is actually being written.