Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dynamic walking to validate unique resource keys #1614

Merged
merged 50 commits into from
Jul 29, 2024
Merged

Use dynamic walking to validate unique resource keys #1614

merged 50 commits into from
Jul 29, 2024

Commits on Jul 18, 2024

  1. rename Location -> Locations. Also add bundle.config.GetLocations fun… 

    …ction and modify all diagnostics paths to be relative to the bundle root path
    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4bedb54 View commit details
    Browse the repository at this point in the history

  2. validate.Location() -> validate.Locations()

    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    7ab131f View commit details
    Browse the repository at this point in the history

  3. fix TestSyncIncludeExcludeNoMatchesTest

    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    39b3eea View commit details
    Browse the repository at this point in the history

  4. patch to transform location -> locations

    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    14a200a View commit details
    Browse the repository at this point in the history

  5. add support for printing multiple locations in validate errors and wa… 

    …rnings
    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    b380344 View commit details
    Browse the repository at this point in the history

  6. newlines in python_diagnostics_test.go

    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    50b8fa5 View commit details
    Browse the repository at this point in the history

  7. newlines in python_mutator_test.go

    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    4d1e2a0 View commit details
    Browse the repository at this point in the history

  8. clean up

    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    3b8fc61 View commit details
    Browse the repository at this point in the history

  9. only select single location for undefined job_cluster_key

    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    83558a6 View commit details
    Browse the repository at this point in the history

  10. single location for validate_sync_patterns.go

    @shreyas-goenka
    shreyas-goenka committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    d9b8902 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. add cyan color to location

    @shreyas-goenka
    shreyas-goenka committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    5b94edd View commit details
    Browse the repository at this point in the history

  2. Fix test in python_diagnostics_test.go

    @shreyas-goenka
    shreyas-goenka committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    52c2d2e View commit details
    Browse the repository at this point in the history

  3. fix comment for Diagnostic.Locations

    @shreyas-goenka
    shreyas-goenka committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6ed74d0 View commit details
    Browse the repository at this point in the history

  4. include multiple locations for unknown field warning

    @shreyas-goenka
    shreyas-goenka committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    1202bcc View commit details
    Browse the repository at this point in the history

  5. fmt

    @shreyas-goenka
    shreyas-goenka committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    16072f6 View commit details
    Browse the repository at this point in the history

  6. Error on duplicate resource keys after YAML files have been loaded

    @shreyas-goenka
    shreyas-goenka committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    6c24df8 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Associate multiple paths with a diagnostic

    @shreyas-goenka
    shreyas-goenka committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    0d76a42 View commit details
    Browse the repository at this point in the history

  2. add tests and modify rendering

    @shreyas-goenka
    shreyas-goenka committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    14cd225 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. fix unit tests

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a550760 View commit details
    Browse the repository at this point in the history

  2. wip

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    21781fe View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin' into error-when-dup-resource

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b78754d View commit details
    Browse the repository at this point in the history

  4. Merge branch 'multi-path-diagnostics' into error-when-dup-resource

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a1e504f View commit details
    Browse the repository at this point in the history

  5. Merge remote-tracking branch 'origin' into diag-multiple-locations

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a602858 View commit details
    Browse the repository at this point in the history

  6. merge

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    83183fe View commit details
    Browse the repository at this point in the history

  7. first version

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a489095 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin' into multi-path-diagnostics

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    841deea View commit details
    Browse the repository at this point in the history

  9. inline code to render paths in template

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a1f1f5c View commit details
    Browse the repository at this point in the history

  10. Merge remote-tracking branch 'origin' into error-when-dup-resource

    @shreyas-goenka
    shreyas-goenka committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    bb32270 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. merge

    @shreyas-goenka
    shreyas-goenka committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    4fc6ce6 View commit details
    Browse the repository at this point in the history

  2. fmt

    @shreyas-goenka
    shreyas-goenka committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    24338e2 View commit details
    Browse the repository at this point in the history

  3. enforce sorted mapping walks by default, and get the tests ready

    @shreyas-goenka
    shreyas-goenka committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    be5361c View commit details
    Browse the repository at this point in the history

  4. add comment for the validation mutator

    @shreyas-goenka
    shreyas-goenka committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    ef2b64d View commit details
    Browse the repository at this point in the history

  5. coverage for the multiple resources case

    @shreyas-goenka
    shreyas-goenka committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    76ed78d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin' into multi-path-diagnostics

    @shreyas-goenka
    shreyas-goenka committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    b9aade4 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. fmt

    @shreyas-goenka
    shreyas-goenka committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    4f0aaf0 View commit details
    Browse the repository at this point in the history

  2. merge new paths

    @shreyas-goenka
    shreyas-goenka committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    04cb868 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin' into error-when-dup-resource

    @shreyas-goenka
    shreyas-goenka committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    556a3d2 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @shreyas-goenka
    shreyas-goenka committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    b4c9379 View commit details
    Browse the repository at this point in the history

  5. -

    @shreyas-goenka
    shreyas-goenka committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    ee68e78 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'origin' into error-when-dup-resource

    @shreyas-goenka
    shreyas-goenka committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    c2908ab View commit details
    Browse the repository at this point in the history

  7. nit

    @shreyas-goenka
    shreyas-goenka committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    0c2238b View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2024

  1. remove unnecessary unit tests

    @shreyas-goenka
    shreyas-goenka committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    04b270b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin' into error-when-dup-resource

    @shreyas-goenka
    shreyas-goenka committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    447764e View commit details
    Browse the repository at this point in the history

  3. fix basic test

    @shreyas-goenka
    shreyas-goenka committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    29cad8c View commit details
    Browse the repository at this point in the history

  4. some cleanup

    @shreyas-goenka
    shreyas-goenka committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    f1ffa59 View commit details
    Browse the repository at this point in the history

  5. fix windows tests

    @shreyas-goenka
    shreyas-goenka committed Jul 26, 2024
    Configuration menu
    Copy the full SHA
    8298f7d View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. combine paths and locations maps into one

    @shreyas-goenka
    shreyas-goenka committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    c441308 View commit details
    Browse the repository at this point in the history

  2. sort lcoations and paths inline instead

    @shreyas-goenka
    shreyas-goenka committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d1b071c View commit details
    Browse the repository at this point in the history

  3. add comment for why we need to clone the path

    @shreyas-goenka
    shreyas-goenka committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    fa9cc1b View commit details
    Browse the repository at this point in the history

  4. fmt

    @shreyas-goenka
    shreyas-goenka committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    75108ab View commit details
    Browse the repository at this point in the history