Add DATABRICKS_BUNDLE_TMP env variable #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
reviewed
Jun 12, 2023
| // CacheDir returns directory to use for temporary files for this bundle. | ||
| // Scoped to the bundle's environment. | ||
| func (b *Bundle) CacheDir(paths ...string) (string, error) { | ||
| if b.Config.Bundle.Environment == "" { | ||
| panic("environment not set") | ||
| } | ||
|
|
||
| cacheDirName, exists := os.LookupEnv("DATABRICKS_BUNDLE_TMP") |
There was a problem hiding this comment.
shouldn't we use the root dir instead? e.g. there's already the env variable for root
There was a problem hiding this comment.
It was @pietern suggestion. I think the rationale is that we do want to keep some files in ".databricks"
There was a problem hiding this comment.
The BUNDLE_ROOT env var is to specify the root of the bundle sources if it cannot be derived from $PWD.
(we should rename that to DATABRICKS_BUNDLE_ROOT btw...).
|
@kanterov Thanks for the PR. Could you add a unit test for this as well? Without one this could regress in the future. |
|
@pietern I've added tests, please take a look again |
pietern
reviewed
Jun 14, 2023
pietern
approved these changes
Jun 15, 2023
Merged
pietern
added a commit
that referenced
this pull request
Jun 28, 2023
## Changes CLI: * Add --absolute flag for ls command ([#508](#508)). * Add dbfs scheme prefix to paths in cp command output ([#516](#516)). * Add provider detection to the repos create command ([#528](#528)). * Added configure-cluster flag for auth login ([#500](#500)). * Added prompts for Databricks profile for auth login command ([#502](#502)). * Allow specifying repo by path for repos commands ([#526](#526)). * Decode contents by default in workspace export command ([#531](#531)). * Fixed jobs create command to only accept JSON payload ([#498](#498)). * Make local files default for fs commands ([#506](#506)). * Remove \r from new line print statments ([#509](#509)). * Remove extra call to filer.Stat in dbfs filer.Read ([#515](#515)). * Update alerts command integration test ([#512](#512)). * Update variable regex to support hyphens ([#503](#503)). Bundles: * Add DATABRICKS_BUNDLE_TMP env variable ([#462](#462)). * Update Terraform provider schema structs ([#504](#504)). Dependencies: * Bump github.com/databricks/databricks-sdk-go from 0.9.1-0.20230614092458-b5bbc1c8dabb to 0.10.0 ([#497](#497)). Internal: * Use direct download for workspace filer read ([#514](#514)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add DATABRICKS_BUNDLE_TMP env variable. It allows using a temporary directory instead of writing to
$CWD/.databricks/bundleTests
I added unit tests