Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prompts for Databricks profile for auth login command #502

Merged
merged 5 commits into from
Jun 21, 2023

Conversation

andrewnester
Copy link
Contributor

@andrewnester andrewnester commented Jun 20, 2023

Changes

Added prompts for Databricks profile for auth login command

Tests

andrew.nester@HFW9Y94129 cli % ./cli auth login https://xxxx-databricks.com
✔ Databricks Profile Name: my-profile█

cmd/auth/profiles.go Outdated Show resolved Hide resolved
cmd/auth/login.go Outdated Show resolved Hide resolved
cmd/auth/login.go Outdated Show resolved Hide resolved
Copy link
Contributor

@pietern pietern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure LGTM, UX comments

cmd/auth/login.go Show resolved Hide resolved
libs/auth/oauth.go Show resolved Hide resolved
cmd/auth/login.go Outdated Show resolved Hide resolved
@pietern pietern requested a review from nfx June 21, 2023 10:56
@pietern
Copy link
Contributor

pietern commented Jun 21, 2023

@nfx FYI

@andrewnester andrewnester merged commit 7db1990 into main Jun 21, 2023
@andrewnester andrewnester deleted the prompt-profile branch June 21, 2023 10:58
@pietern pietern mentioned this pull request Jun 28, 2023
pietern added a commit that referenced this pull request Jun 28, 2023
## Changes

CLI:
* Add --absolute flag for ls command
([#508](#508)).
* Add dbfs scheme prefix to paths in cp command output
([#516](#516)).
* Add provider detection to the repos create command
([#528](#528)).
* Added configure-cluster flag for auth login
([#500](#500)).
* Added prompts for Databricks profile for auth login command
([#502](#502)).
* Allow specifying repo by path for repos commands
([#526](#526)).
* Decode contents by default in workspace export command
([#531](#531)).
* Fixed jobs create command to only accept JSON payload
([#498](#498)).
* Make local files default for fs commands
([#506](#506)).
* Remove \r from new line print statments
([#509](#509)).
* Remove extra call to filer.Stat in dbfs filer.Read
([#515](#515)).
* Update alerts command integration test
([#512](#512)).
* Update variable regex to support hyphens
([#503](#503)).

Bundles:
* Add DATABRICKS_BUNDLE_TMP env variable
([#462](#462)).
* Update Terraform provider schema structs
([#504](#504)).

Dependencies:
* Bump github.com/databricks/databricks-sdk-go from
0.9.1-0.20230614092458-b5bbc1c8dabb to 0.10.0
([#497](#497)).

Internal:
* Use direct download for workspace filer read
([#514](#514)).
@andrewnester andrewnester mentioned this pull request Jul 3, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants