Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --absolute flag for ls command #508

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Add --absolute flag for ls command #508

merged 5 commits into from
Jun 27, 2023

Conversation

shreyas-goenka
Copy link
Contributor

@shreyas-goenka shreyas-goenka commented Jun 21, 2023 •
edited
Loading

tested manually

@shreyas-goenka
Copy link
Contributor Author

example output:

shreyas.goenka@THW32HFW6T bricks % cli fs ls dbfs:/FileStore --absolute -l
FILE      278154 2023-03-05T16:27:11Z dbfs:/FileStore/babynames.csv
DIRECTORY 0 2022-10-03T08:18:02Z dbfs:/FileStore/jars
FILE      98 2023-06-05T15:01:35Z dbfs:/FileStore/my_notebook_task.py
DIRECTORY 0 2022-06-23T15:45:57Z dbfs:/FileStore/tables
DIRECTORY 0 2023-03-26T20:18:06Z dbfs:/FileStore/terraform-test

shreyas.goenka@THW32HFW6T bricks % cli fs ls dbfs:/FileStore --absolute
dbfs:/FileStore/babynames.csv
dbfs:/FileStore/jars
dbfs:/FileStore/my_notebook_task.py
dbfs:/FileStore/tables
dbfs:/FileStore/terraform-test

andrewnester
andrewnester requested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@andrewnester andrewnester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add unit / integration test for this?

cmd/fs/ls.go Outdated Show resolved Hide resolved
@shreyas-goenka
Copy link
Contributor Author

shreyas-goenka commented Jun 22, 2023 •
edited
Loading

Added an integration test

@shreyas-goenka shreyas-goenka merged commit 54148ff into main Jun 27, 2023
4 checks passed
@shreyas-goenka shreyas-goenka deleted the ls-absollute branch June 27, 2023 14:07
@pietern pietern mentioned this pull request Jun 28, 2023
Merged
pietern added a commit that referenced this pull request Jun 28, 2023
@pietern
Release v0.200.1 (#532)
f42279f 
## Changes

CLI:
* Add --absolute flag for ls command
([#508](#508)).
* Add dbfs scheme prefix to paths in cp command output
([#516](#516)).
* Add provider detection to the repos create command
([#528](#528)).
* Added configure-cluster flag for auth login
([#500](#500)).
* Added prompts for Databricks profile for auth login command
([#502](#502)).
* Allow specifying repo by path for repos commands
([#526](#526)).
* Decode contents by default in workspace export command
([#531](#531)).
* Fixed jobs create command to only accept JSON payload
([#498](#498)).
* Make local files default for fs commands
([#506](#506)).
* Remove \r from new line print statments
([#509](#509)).
* Remove extra call to filer.Stat in dbfs filer.Read
([#515](#515)).
* Update alerts command integration test
([#512](#512)).
* Update variable regex to support hyphens
([#503](#503)).

Bundles:
* Add DATABRICKS_BUNDLE_TMP env variable
([#462](#462)).
* Update Terraform provider schema structs
([#504](#504)).

Dependencies:
* Bump github.com/databricks/databricks-sdk-go from
0.9.1-0.20230614092458-b5bbc1c8dabb to 0.10.0
([#497](#497)).

Internal:
* Use direct download for workspace filer read
([#514](#514)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pietern pietern pietern approved these changes

@andrewnester andrewnester andrewnester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shreyas-goenka @pietern @andrewnester