Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider detection to the repos create command #528

Merged
merged 2 commits into from
Jun 27, 2023

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jun 26, 2023

Changes

Closes #527.

Tests

Integration tests pass.

Base automatically changed from repos-by-path to main June 26, 2023 23:37
@pietern pietern force-pushed the repos-create-infer-provider branch from 09935e1 to ecb9f4c Compare June 26, 2023 23:38
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@lennartkats-db lennartkats-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and it's pragmatic. It's a bit unfortunate that this duplicates functionality from the UI. Did you ask the Repos team if they have considered making this part of their API?

@pietern
Copy link
Contributor Author

pietern commented Jun 27, 2023

@lennartkats-db No, this is a pure replication of what is done both in the legacy CLI and the Terraform provider.

@pietern pietern merged commit c64a333 into main Jun 27, 2023
4 checks passed
@pietern pietern deleted the repos-create-infer-provider branch June 27, 2023 12:17
@pietern pietern mentioned this pull request Jun 28, 2023
pietern added a commit that referenced this pull request Jun 28, 2023
## Changes

CLI:
* Add --absolute flag for ls command
([#508](#508)).
* Add dbfs scheme prefix to paths in cp command output
([#516](#516)).
* Add provider detection to the repos create command
([#528](#528)).
* Added configure-cluster flag for auth login
([#500](#500)).
* Added prompts for Databricks profile for auth login command
([#502](#502)).
* Allow specifying repo by path for repos commands
([#526](#526)).
* Decode contents by default in workspace export command
([#531](#531)).
* Fixed jobs create command to only accept JSON payload
([#498](#498)).
* Make local files default for fs commands
([#506](#506)).
* Remove \r from new line print statments
([#509](#509)).
* Remove extra call to filer.Stat in dbfs filer.Read
([#515](#515)).
* Update alerts command integration test
([#512](#512)).
* Update variable regex to support hyphens
([#503](#503)).

Bundles:
* Add DATABRICKS_BUNDLE_TMP env variable
([#462](#462)).
* Update Terraform provider schema structs
([#504](#504)).

Dependencies:
* Bump github.com/databricks/databricks-sdk-go from
0.9.1-0.20230614092458-b5bbc1c8dabb to 0.10.0
([#497](#497)).

Internal:
* Use direct download for workspace filer read
([#514](#514)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CLI doesn't support automatic detection of Git providers
3 participants