Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG template #588

Merged
merged 3 commits into from
Jul 27, 2023
Merged

Update CHANGELOG template #588

merged 3 commits into from
Jul 27, 2023

Conversation

pietern
Copy link
Contributor

@pietern pietern commented Jul 19, 2023

Made the recent release reflect this template.

Made the recent release reflect this template.
@pietern pietern requested a review from nfx July 19, 2023 07:40
nfx
nfx previously requested changes Jul 19, 2023
.codegen/changelog.md.tmpl Show resolved Hide resolved
@pietern pietern requested a review from mgyucht July 26, 2023 13:16
Copy link
Contributor

@mgyucht mgyucht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one micronit. Given that our release automation tool prompts the user to update the changelog, we should make sure that this is done each time we cut a new release of the CLI. (We should be doing that anyways, but it will be much more obvious when this isn't done for the CLI compared to other projects.)

.codegen/changelog.md.tmpl Outdated Show resolved Hide resolved
Co-authored-by: Miles Yucht <miles@databricks.com>
@pietern pietern enabled auto-merge July 27, 2023 09:25
@mgyucht mgyucht dismissed nfx’s stale review July 27, 2023 10:47

The concern in this review has been mitigated with changes to our release automation tooling.

@pietern pietern added this pull request to the merge queue Jul 27, 2023
Merged via the queue into main with commit e3a181b Jul 27, 2023
4 checks passed
@pietern pietern deleted the update-changelog branch July 27, 2023 10:54
@mgyucht mgyucht mentioned this pull request Jul 27, 2023
github-merge-queue bot pushed a commit that referenced this pull request Jul 27, 2023
Breaking Change:
* Require include glob patterns to be explicitly defined
([#602](#602)).

Bundles:
* Add support for more SDK config options
([#587](#587)).
* Add template renderer for Databricks templates
([#589](#589)).
* Fix formatting in renderer.go
([#593](#593)).
* Fixed python wheel test
([#608](#608)).
* Auto detect Python wheel packages and infer build command
([#603](#603)).
* Added support for artifacts building for bundles
([#583](#583)).
* Add support for cloning repositories
([#544](#544)).
* Add regexp compile helper function for templates
([#601](#601)).
* Add unit test that raw strings are printed as is
([#599](#599)).

Internal:
* Fix tests under ./cmd/configure if DATABRICKS_TOKEN is set
([#605](#605)).
* Remove dependency on global state in generated commands
([#595](#595)).
* Remove dependency on global state for the root command
([#606](#606)).
* Add merge_group trigger for build
([#612](#612)).
* Added support for build command chaining and error on missing wheel
([#607](#607)).
* Add TestAcc prefix to filer test and fix any failing tests
([#611](#611)).
* Add url parse helper function for templates
([#600](#600)).
* Remove dependency on global state for remaining commands
([#613](#613)).
* Update CHANGELOG template
([#588](#588)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants