Move openapi generator to deco tool #765
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfx
suggested changes
Jan 11, 2024
There was a problem hiding this comment.
I think https://github.com/google/copybara is a better option overall.
Comment on lines
-18
to
-22
| // Named holds common methods for identifying and describing things | ||
| type Named struct { | ||
| Name string | ||
| Description string | ||
| } |
There was a problem hiding this comment.
I rely on this in a couple of tools. This change is too big. Please setup https://github.com/google/copybara to sync code as the stop-gap measure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To simplify changes to the code generator, as well as to enable us to take additional dependencies in the code generator without adding to the Go SDK, we're moving the OpenAPI codegen components to the internal
decotool. We may later open-source an updated version of this if/when we make our OpenAPI specification public.Tests
make testpassingmake fmtapplied